feat(unstable): add more options to Deno.createHttpClient #17385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to add tests; unsure exactly how to test some of these though |
# Conflicts: # cli/file_fetcher.rs # cli/http_util.rs # ext/fetch/lib.rs
bartlomieju
reviewed
May 20, 2023
| @@ -1746,7 +1747,7 @@ mod tests { | |||
|
|
|||
| fn create_test_client() -> HttpClient { | |||
| HttpClient::from_client( | |||
| create_http_client("test_client", None, vec![], None, None, None) | |||
| create_http_client("test_client", CreateHttpClientOptions::default()) | |||
|
LGTM |
| /** Set an optional timeout for idle sockets being kept-alive. | ||
| * Set to false to disable the timeout. */ | ||
| poolIdleTimeout?: number | false; | ||
| /** Whether HTTP/1.1 is allowed or not. */ |
There was a problem hiding this comment.
Allowed -> enabled. Should either say it defaults to true (but that is confusing), so probably should be disableHttp1: boolean. Wdyt?
There was a problem hiding this comment.
Should either say it defaults to true (but that is confusing)
How so?
There was a problem hiding this comment.
Because undefined casts to false, not true. http1: undefined should therefore cast to http1: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11056
Closes #13636