Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): date and unwrap handling #17369

Merged
merged 6 commits into from
Jan 13, 2023
Merged

fix(napi): date and unwrap handling #17369

merged 6 commits into from
Jan 13, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 12, 2023 •
edited
Loading

Closes #17346

@bartlomieju bartlomieju changed the title [WIP] fix(napi): date and unwrap handling fix(napi): date and unwrap handling Jan 13, 2023
@bartlomieju bartlomieju marked this pull request as ready for review January 13, 2023 01:32
almeidx
almeidx reviewed Jan 13, 2023
View reviewed changes
foo.js Outdated Show resolved Hide resolved
crowlKats
crowlKats approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 291dcc3 into denoland:main Jan 13, 2023
@bartlomieju bartlomieju deleted the napi_debug_polars branch January 13, 2023 11:53
dsherret pushed a commit that referenced this pull request Jan 13, 2023
@bartlomieju @dsherret
fix(napi): date and unwrap handling (#17369)
d05ebcb
dsherret pushed a commit that referenced this pull request Jan 13, 2023
@bartlomieju @dsherret
fix(napi): date and unwrap handling (#17369)
7ed2c13
MierenManz added a commit to MierenManz/oned that referenced this pull request Jan 20, 2023
@MierenManz
Revert "fix(napi): date and unwrap handling (denoland#17369)"
58dd4e9 
This reverts commit 291dcc3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@crowlKats crowlKats crowlKats approved these changes

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug while running polars
3 participants
@bartlomieju @crowlKats @almeidx