fix(lsp): timeout registry config fetching after 10 seconds

[crowlKats]

Fixes #16426.

Or would we rather want to timeout directly in FileFetcher.fetch?

[bartlomieju]

Besides timeout (which I think should be lower like 10s) could you make sure that LSP is not downloading these files more often than once per day (or at least every hour)?

[crowlKats]

could you make sure that LSP is not downloading these files more often than once per day (or at least every hour)?

below the changes i added it says they are cached for a week

[bartlomieju]

below the changes i added it says they are cached for a week

I see, it's confusing that LSP shows "Download ..." on each startup. Maybe we could remove it if the file is not actually downloaded?

[crowlKats]

below the changes i added it says they are cached for a week

I see, it's confusing that LSP shows "Download ..." on each startup. Maybe we could remove it if the file is not actually downloaded?

the download message happens when starting to make a fetch, which i think is right behaviour; obviously this means it will log that even if timed out.

[bartlomieju]

below the changes i added it says they are cached for a week

I see, it's confusing that LSP shows "Download ..." on each startup. Maybe we could remove it if the file is not actually downloaded?

the download message happens when starting to make a fetch, which i think is right behaviour; obviously this means it will log that even if timed out.

Okay, now I'm confused - if the message happens when starting a fetch, does that mean that LSP is actually downloading these files or not? If not, then I think this message should be deferred to when the actual request is getting fired off.

[crowlKats]

the log happens here

deno/cli/file_fetcher.rs

Lines 450 to 455 in fac6447

	log::log!(
	self.download_log_level,
	"{} {}",
	colors::green("Download"),
	specifier
	);

the fetch call is 10 lines later

[aapoalas]

Looks fine to me.