Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use Node 18 #17355

Merged
merged 2 commits into from
Jan 11, 2023
Merged

chore(ci): use Node 18 #17355

merged 2 commits into from
Jan 11, 2023

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 11, 2023

Some caching steps are prefixed with 18-, which I assume represents that Node 18 should be in use rather than Node 17. Node 18 is also the latest LTS version.

@iuioiua iuioiua changed the title fix: use Node 18 in CI fix(ci): use Node 18 Jan 11, 2023
@iuioiua iuioiua marked this pull request as ready for review January 11, 2023 21:21
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some caching steps are prefixed with 18-, which I assume represents that Node 18 should be in use rather than Node 17

We increment this number whenever we want to cache bust. It happened to be on 18.

@dsherret dsherret merged commit cc4bc2c into denoland:main Jan 11, 2023
@dsherret
Copy link
Member

Meant to merge that as a chore.

@dsherret dsherret changed the title fix(ci): use Node 18 chore(ci): use Node 18 Jan 11, 2023
dsherret pushed a commit that referenced this pull request Jan 13, 2023
dsherret pushed a commit that referenced this pull request Jan 13, 2023
@iuioiua iuioiua deleted the update-to-use-node-18 branch February 22, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants