chore(ci): save cache on main at end of workflow #17354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the problem was probably introduced in #17201. Sorry about it |
|
@kt3k oh, that was more recent than I thought. Not a big deal! |
|
More my bad 😅 |
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
Seems like our caching was totally broken. We need to save the cache after building and not before. ``` Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. Warning: Cache save failed. ```
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
Seems like our caching was totally broken. We need to save the cache after building and not before. ``` Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. Warning: Cache save failed. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like our caching was totally broken. We need to save the cache after building and not before.
On main:
On PRs: