chore(ci): do not run CI on draft PRs unless explicitly run via commit message #17350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 11, 2023
| @@ -201,541 +248,549 @@ const ci = { | |||
| submodules: false, | |||
| }, | |||
| }, | |||
| submoduleStep("./test_util/std"), | |||
There was a problem hiding this comment.
The only change I made below was wrap all the steps in a ...cancelEarlyIfDraftPr(
dsherret
commented
Jan 11, 2023
| - name: Clone submodule ./test_util/wpt | ||
| run: git submodule update --init --recursive --depth=1 -- ./test_util/wpt | ||
| if: matrix.job == 'test' | ||
| if: steps.exit_early.outputs.EXIT_EARLY != 'true' && (matrix.job == 'test') |
There was a problem hiding this comment.
Again, the output kind of sucks, but we're maintaining the ci.generate.ts file now so this file doesn't matter that much.
bartlomieju
approved these changes
Jan 11, 2023
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
…t message (#17350) This will help us reduce CI time during development. The CI can be explicitly run on draft PRs by adding `[ci]` to the commit message.
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
…t message (#17350) This will help us reduce CI time during development. The CI can be explicitly run on draft PRs by adding `[ci]` to the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested:
This will help us reduce CI time during development. The CI can be explicitly run on draft PRs by adding
[ci]to the commit message.