chore(ci): ci refactor - Part 1 - Generate ci yaml by js #17335
Conversation
| WPT_FYI_PW: ${{ secrets.WPT_FYI_PW }} | ||
| GITHUB_TOKEN: ${{ secrets.DENOBOT_PAT }} | ||
| run: | | ||
| WPT_FYI_PW: '${{ secrets.WPT_FYI_PW }}' |
There was a problem hiding this comment.
I'm not so familiar with YAML, but in this situation both sides are equivalent? Adding quotes doesn't change how it's evaluated?
There was a problem hiding this comment.
'${{ matrix.os }}', name: '${{ matrix.job }} ${{ matrix.profile }} ${{ matrix.os }}', etc. seem to work above, so I assume this works too.
| - name: Run benchmarks | ||
| if: matrix.job == 'bench' && !startsWith(github.ref, 'refs/tags/') | ||
| if: 'matrix.job == ''bench'' && !startsWith(github.ref, ''refs/tags/'')' |
There was a problem hiding this comment.
This two single quotes looks strange there around bench
There was a problem hiding this comment.
Yeah, I'm not sure what I can do with deno_std to get this to be left alone
There was a problem hiding this comment.
The important thing is more the ci.generate.ts because we're not maintaining this file anymore.
|
Genuine question: what benefit does generating |
|
@iuioiua YAML is hard to maintain. By generating it instead we can more easily do complex things (ex. do stuff like apply a condition to a group of steps at one time instead of copying and pasting a condition to each step). |
|
Ah, I see! Is there any reason why |
|
I don't think it matters that much. Importing from the url does make it easier to make changes to that file when the std submodule isn't checked out of git. |
I was looking at #14448 and I think we need to do this in progressive steps to get it merged. Here's part 1, which is just a straight refactor of our yaml file being generated by javascript.
Next steps: