Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(napi): support for env cleanup hooks #17324

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jan 9, 2023

Closes #16925

This commit adds support for "napi_add_env_cleanup_hook" and
"napi_remove_env_cleanup_hook" function for Node-API.

@bartlomieju bartlomieju changed the title [WIP] fix(napi): support for env cleanup hooks fix(napi): support for env cleanup hooks Jan 10, 2023
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with some small changes

ext/napi/lib.rs Outdated Show resolved Hide resolved
cli/napi/env.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju merged commit 14ada3d into denoland:main Jan 10, 2023
@bartlomieju bartlomieju deleted the node_api_cleanup_hooks branch January 10, 2023 23:38
dsherret pushed a commit that referenced this pull request Jan 13, 2023
This commit adds support for "napi_add_env_cleanup_hook" and
"napi_remove_env_cleanup_hook" function for Node-API.
dsherret pushed a commit that referenced this pull request Jan 13, 2023
This commit adds support for "napi_add_env_cleanup_hook" and
"napi_remove_env_cleanup_hook" function for Node-API.
MierenManz added a commit to MierenManz/oned that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

napi_add_env_cleanup_hook is not implemented
3 participants