feat(core): allow specifying name and dependencies of an Extension #17301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
changed the title
bartlomieju
reviewed
Jan 8, 2023
There was a problem hiding this comment.
Unsure if additionally we should:
make specifying a name mandatory
panic if there are multiple extensions defined with the same name
I say yes - name should be a mandatory argument to Extension::builder() (eg. Extension::builder("deno_console") method and we should panic if there are multiple extension with the same name
bartlomieju
changed the title
bartlomieju
approved these changes
Jan 8, 2023
Co-authored-by: Bartek Iwańczuk <[email protected]>
dsherret
pushed a commit
that referenced
this pull request
Jan 13, 2023
dsherret
pushed a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to optionally specify a name and a set of dependencies (which are other
Extensions) in anExtension, to provide a better error message when using the extension crates.Unsure if additionally we should: