New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add `copyright_checker` tool and add the missing copyright of … #17285

Merged

kt3k merged 8 commits into denoland:main from attila-lin:dev/copy

Jan 13, 2023

Contributor

attila-lin commented Jan 6, 2023

…code files

someday may be added to the CI

attila-lin added 2 commits

January 6, 2023 17:51


chore: add copyright_checker tool and add the missing copyright of …

b9f9e04

…code files

someday may be added to the CI

fmt

9253bbd

dsherret reviewed

View reviewed changes

tools/copyright_checker.js Show resolved Hide resolved

kt3k reviewed

View reviewed changes

tools/copyright_checker.js Outdated Show resolved Hide resolved

dsherret reviewed

View reviewed changes

tools/copyright_checker.js Outdated Show resolved Hide resolved

dsherret approved these changes

View reviewed changes

Member

dsherret left a comment

LGTM and thanks!

Would be nice to have this done on the lint step in the CI. I very often forget to add the copyright line.

kt3k reviewed

View reviewed changes

tools/copyright_checker.js Outdated Show resolved Hide resolved

kt3k reviewed

View reviewed changes

tools/copyright_checker.js Outdated Show resolved Hide resolved

kt3k reviewed

View reviewed changes

tools/copyright_checker.js Outdated Show resolved Hide resolved

Member

kt3k commented Jan 6, 2023

Otherwise look good to me

attila-lin added 2 commits

January 7, 2023 12:04


fix review

1ab29aa

fmt

f8c5ee1

Contributor Author

attila-lin commented Jan 7, 2023

Would be nice to have this done on the lint step in the CI. I very often forget to add the copyright line.

I will make a CI pr next time ASAP. 😄

attila-lin and others added 4 commits

January 7, 2023 12:19


lint

b759834


Merge remote-tracking branch 'origin/main' into dev/copy

792a54c


Merge branch 'main' into dev/copy

e8cf16c


fix lint error

797fa15

kt3k approved these changes

View reviewed changes

Member

kt3k left a comment

LGTM

kt3k merged commit a00e432 into denoland:main

dsherret pushed a commit that referenced this pull request


chore: add copyright_checker tool and add the missing copyright (#1…

baf8db1

…7285)

dsherret pushed a commit that referenced this pull request


chore: add copyright_checker tool and add the missing copyright (#1…

3f270c1

…7285)

attila-lin deleted the dev/copy branch

March 14, 2023 04:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment