Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/fetch): remove Response.trailer from types #17284

Merged
merged 3 commits into from
Jan 15, 2023
Merged

fix(ext/fetch): remove Response.trailer from types #17284

merged 3 commits into from
Jan 15, 2023

Conversation

GJZwiers
Copy link
Contributor

@GJZwiers GJZwiers commented Jan 6, 2023

The trailer property is not implemented in 23_response.js but it is listed in the types for Response. This PR removes the property from that file. Alternatively, it could be added to 23_response.js but throw an Error, if Deno plans to add this property in the future?

Fixes #16200.

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this isnt part of the spec since whatwg/fetch#979

@crowlKats crowlKats changed the title chore(ext/fetch): remove Response.trailer from types fix(ext/fetch): remove Response.trailer from types Jan 15, 2023
@crowlKats crowlKats enabled auto-merge (squash) January 15, 2023 04:23
@crowlKats crowlKats merged commit 2f15efb into denoland:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Trailers advertised in Response type but unavailable in runtime
2 participants