Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up unwrap and clone #17282

Merged
merged 6 commits into from
Jan 15, 2023
Merged

Conversation

attila-lin
Copy link
Contributor

No description provided.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert changes to imports ordering? They are very noise and don't change anything besides making git diffs bigs

This reverts commit 8ecb652.
@attila-lin
Copy link
Contributor Author

Reverted.

I have a little bit code style cleanliness. 😀

@crowlKats
Copy link
Member

@attila-lin could you fix the merge conflicts?

@littledivy littledivy changed the title refactor(cli,core,ext,rt): clean up unwrap and clone refactor: clean up unwrap and clone Jan 15, 2023
@littledivy littledivy enabled auto-merge (squash) January 15, 2023 03:49
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit fd85f84 into denoland:main Jan 15, 2023
bartlomieju pushed a commit that referenced this pull request Jan 16, 2023
@attila-lin attila-lin deleted the dev/unwrap branch March 14, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants