Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Add Generator and AsyncGenerator to promordials #17241

Merged
merged 8 commits into from
Jan 15, 2023
Merged

fix(core): Add Generator and AsyncGenerator to promordials #17241

merged 8 commits into from
Jan 15, 2023

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Jan 2, 2023 •
edited
Loading

  • Add Generator and AsyncGenerator to promordials
    • Call AsyncGeneratorPrototypeNext instead of calling next directly
    • Prevent to use for-await-of
  • Update internal.d.ts

@petamoriken petamoriken marked this pull request as ready for review January 2, 2023 11:53
@bartlomieju
Copy link
Member

@littledivy please review

kt3k
kt3k approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

littledivy
littledivy approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@littledivy littledivy enabled auto-merge (squash) January 15, 2023 04:05
@littledivy littledivy merged commit 1dc3609 into denoland:main Jan 15, 2023
@petamoriken petamoriken deleted the add/generator-to-promordials branch January 15, 2023 05:01
bartlomieju pushed a commit that referenced this pull request Jan 16, 2023
@petamoriken @bartlomieju
fix(core): Add Generator and AsyncGenerator to promordials (#17241)
ac056e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petamoriken @bartlomieju @kt3k @littledivy