Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): treat empty string config value as None #17227

Merged
merged 4 commits into from
Jan 3, 2023
Merged

fix(lsp): treat empty string config value as None #17227

merged 4 commits into from
Jan 3, 2023

Conversation

crowlKats
Copy link
Member

Fixes #14630

bartlomieju
bartlomieju reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other field values that might contain empty strings? Could you update their handling too?

bartlomieju
bartlomieju approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret changed the title fix(lsp): treat empty config as None fix(lsp): treat empty string config value as None Jan 1, 2023
dsherret
dsherret reviewed Jan 1, 2023
View reviewed changes
cli/lsp/config.rs
d: D,
) -> Result<Option<String>, D::Error> {
let o: Option<String> = Option::deserialize(d)?;
Ok(o.filter(|s| !s.is_empty()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should do !s.trim().is_empty()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, seems a bit weird

@crowlKats crowlKats merged commit 7716449 into denoland:main Jan 3, 2023
bartlomieju pushed a commit that referenced this pull request Jan 5, 2023
@crowlKats @bartlomieju
fix(lsp): treat empty string config value as None (#17227)
8221736 
Fixes #14630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Treat "deno.config": "" as "deno.config": null in LSP
3 participants
@crowlKats @dsherret @bartlomieju