Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): report correct cwd when running tests via itest macro #17132

Merged
merged 1 commit into from
Dec 20, 2022
Merged

chore(test): report correct cwd when running tests via itest macro #17132

merged 1 commit into from
Dec 20, 2022

Conversation

kamilogorek
Copy link
Contributor

Based on the few lines above, cwd is not always testdata_dir:

let cwd = if self.temp_cwd {
  deno_dir.path()
} else {
  testdata_dir.as_path()
};

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret changed the title fix(test): Report correct cwd when running tests via itest macro chore(test): report correct cwd when running tests via itest macro Dec 20, 2022
@dsherret dsherret merged commit 2ac575a into denoland:main Dec 20, 2022
@kamilogorek kamilogorek deleted the patch-1 branch December 20, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants