Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime): "Worker::execute_script" returns value #17092

Merged
merged 5 commits into from
Dec 18, 2022
Merged

refactor(runtime): "Worker::execute_script" returns value #17092

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
831f026
feat: add execute_script_with_return function
gofenix Dec 17, 2022
576a47c
fix: return a value in execute_script instead of adding a new api
gofenix Dec 17, 2022
8055bc5
fix: add v8 dependence and fix tests
gofenix Dec 17, 2022
58472c2
fix: use deno_core::v8
gofenix Dec 18, 2022
1ef3a38
fix: cargo fmt worker.rs
gofenix Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add v8 dependence and fix tests
  • Loading branch information
@gofenix
gofenix committed Dec 17, 2022
commit 8055bc5d8fb779a7feb75aeb67fb96966e1a3387
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ signal-hook-registry = "1.4.0"
termcolor = "1.1.3"
tokio.workspace = true
uuid.workspace = true
v8.workspace = true
gofenix marked this conversation as resolved.
Show resolved Hide resolved

[target.'cfg(windows)'.dependencies]
fwdansi.workspace = true
Expand Down
6 changes: 4 additions & 2 deletions runtime/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ impl MainWorker {
// it. Instead we're using global `dispatchEvent` function which will
// used a saved reference to global scope.
"dispatchEvent(new Event('load'))",
)
)?;
Ok(())
}

/// Dispatches "unload" event to the JavaScript runtime.
Expand All @@ -446,7 +447,8 @@ impl MainWorker {
// it. Instead we're using global `dispatchEvent` function which will
// used a saved reference to global scope.
"dispatchEvent(new Event('unload'))",
)
)?;
Ok(())
}

/// Dispatches "beforeunload" event to the JavaScript runtime. Returns a boolean
Expand Down