Use prettier in deno (in //tools/format.ts) #1708
Conversation
kt3k
changed the title
kt3k
force-pushed
the
feature/update-prettier
branch
3 times, most recently
from
e9f669c
to
92fda3d
Compare
tools/util.ts
Outdated
| /** | ||
| * Returns true if the path exists. | ||
| */ | ||
| export function existsSync (path: string): boolean { |
There was a problem hiding this comment.
Style error here - shouldn't be a space between existsSync and parens.
There was a problem hiding this comment.
Yes. Will fix it.
Something is wrong in this branch and formatting doesn't seem working now. I'll look into it.
There was a problem hiding this comment.
std/prettier/main.ts was crashing at //tests/error_syntax.js because the parser throws. The original prettier CLI seems ignoring the file when it can't parse it, and avoids crashing. I added error_syntax.js to skip list to avoid the crash.
There was a problem hiding this comment.
Because of this file: https://github.com/denoland/deno/blob/master/.prettierignore
I guess std/prettier doesn't look at it?
tools/util.ts
Outdated
|
|
||
| /** | ||
| * Returns true if the path exists. | ||
| */ |
There was a problem hiding this comment.
Use a single line for jsdoc comments if possible.
| * Looks up the available deno path with the priority | ||
| * of release -> debug -> global | ||
| */ | ||
| export function lookupDenoPath(): string { |
There was a problem hiding this comment.
Aside: I wonder if the executable location should be available in deno.
There was a problem hiding this comment.
I think that's convenient in some situations, like when deno is unavailable in $PATH.
kt3k
force-pushed
the
feature/update-prettier
branch
2 times, most recently
from
5f95f38
to
949c0f5
Compare
kt3k
force-pushed
the
feature/update-prettier
branch
from
949c0f5
to
09bf5d8
Compare
kt3k
changed the title
| join("tools", "clang"), | ||
| join("js", "deps"), | ||
| join("tests", "badly_formatted.js"), | ||
| join("tests", "error_syntax.js") |
There was a problem hiding this comment.
Please remove .prettierignore if we do this.
| export const executableSuffix = platform.os === "win" ? ".exe" : ""; | ||
|
|
||
| // Returns true if the path exists. | ||
| export function existsSync(path: string): boolean { |
There was a problem hiding this comment.
existsSync is super useful. Maybe we should add it to the core API...
The comment should be jsdoc /** Returns true if the path exists. */
kt3k
force-pushed
the
feature/update-prettier
branch
from
9ebc6a9
to
ddae887
Compare
|
Removed |
No description provided.