refactor(core): add more information when unable to build error #17027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
approved these changes
Dec 13, 2022
| let cb = cb.open(tc_scope); | ||
| let this = v8::undefined(tc_scope).into(); | ||
| let class = v8::String::new(tc_scope, get_class(error)).unwrap(); | ||
| let message = v8::String::new(tc_scope, &format!("{:#}", error)).unwrap(); |
There was a problem hiding this comment.
Oh this is interesting. I didn't notice that we format the rust errors using the Debug trait. Debug traits might include sensitive information (crypto material, file paths, platform info) - we should be more careful with type_error and generic_error.
There was a problem hiding this comment.
I believe it is on purpose, otherwise the error includes only the first line which loses a lot of context in different scenarios. @dsherret we use that in Node compat IIRC?
There was a problem hiding this comment.
If it had a question mark it would be debug. The {:#} is "alternate" form of printing https://doc.rust-lang.org/std/fmt/#sign0 -- with anyhow it includes the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help debug problem in #16963