chore: forward v1.28.3 release commit to main #16884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kt3k <[email protected]>
bartlomieju
reviewed
Dec 1, 2022
cli/npm/resolution/graph.rs
Outdated
| @@ -836,15 +836,13 @@ impl<'a, TNpmRegistryApi: NpmRegistryApi> | |||
| path: &Arc<GraphSpecifierPath>, | |||
| visited_ancestor_versions: &Arc<VisitedVersionsPath>, | |||
| ) -> NpmPackageId { | |||
| let peer_dep_id = Cow::Borrowed(peer_dep_id); | |||
| let mut peer_dep_id = Cow::Borrowed(peer_dep_id); | |||
There was a problem hiding this comment.
There should be no changes to this file while forwarding, please revert
kt3k
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release commit being forwarded back to main for 1.28.3
Please ensure:
To make edits to this PR:
git fetch upstream forward_v1.28.3 && git checkout -b forward_v1.28.3 upstream/forward_v1.28.3Don't need this PR? Close it.
cc @kt3k