Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI to use actions/cache@v3 #16673

Closed
wants to merge 1 commit into from
Closed

chore: update CI to use actions/cache@v3 #16673

wants to merge 1 commit into from

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Nov 16, 2022

This PR updates the CI workflow to use actions/cache@v3 instead of actions/cache@03e00da99d75a2204924908e1cca7902cafce66b which was changed in #10560.

Doing so removes deprecation warnings regarding the use of save-state, set-output and Node.js 12.

@iuioiua iuioiua marked this pull request as ready for review November 16, 2022 21:31
@kt3k
Copy link
Member

kt3k commented Nov 17, 2022

I think we still use the feature of that specific branch (setting CACHE_SKIP_SAVE=true for skipping the cache save), and that feature doesn't seem landed yet to its main. Is a similar feature available in actions/cache@v3?

@iuioiua
Copy link
Collaborator Author

iuioiua commented Nov 18, 2022

You're right. I'll close this PR and instead push for something to happen with actions/cache@03e00da99d75a2204924908e1cca7902cafce66b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants