fix(runtime): fix Deno.hostname on windows #16530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Nov 3, 2022
| // https://github.com/retep998/winapi-rs/issues/296 | ||
| let wsa_startup_result = WSAStartup(MAKEWORD(2, 2), &mut data); | ||
| if wsa_startup_result != 0 { | ||
| panic!("Failed to start winsocket"); |
There was a problem hiding this comment.
Maybe we should return String::from("") in this case?
There was a problem hiding this comment.
I agree. I'll try that in a later PR
littledivy
reviewed
Nov 3, 2022
runtime/ops/os/sys_info.rs
Outdated
Comment on lines
143
to
149
| let mut data = mem::zeroed(); | ||
| // Start winsock to make `GetHostNameW` work correctly | ||
| // https://github.com/retep998/winapi-rs/issues/296 | ||
| let wsa_startup_result = WSAStartup(MAKEWORD(2, 2), &mut data); | ||
| if wsa_startup_result != 0 { | ||
| panic!("Failed to start winsocket"); | ||
| } |
There was a problem hiding this comment.
This should be in a once_cell
littledivy
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix
Deno.hostname()issue on windows. This change starts winsocket before callingGetHostNameWas suggested in retep998/winapi-rs#296closes #16527