Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): fix is_detached_arraybuffer #16478

Merged
merged 3 commits into from
Oct 30, 2022
Merged

fix(napi): fix is_detached_arraybuffer #16478

merged 3 commits into from
Oct 30, 2022

Conversation

marcosc90
Copy link
Contributor

No description provided.

@marcosc90 marcosc90 changed the title fix(napi): napi is_detached_arraybuffer fix(napi): fix is_detached_arraybuffer Oct 29, 2022
@cjihrig
Copy link
Contributor

cjihrig commented Oct 29, 2022

Can you add a test for this?

@marcosc90
Copy link
Contributor Author

marcosc90 commented Oct 29, 2022 •
edited
Loading

Can you add a test for this?

Done! PTAL

littledivy
littledivy approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig cjihrig merged commit 207dd8d into denoland:main Oct 30, 2022
@marcosc90 marcosc90 deleted the napi-ab-is-detached branch October 30, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcosc90 @cjihrig @littledivy