Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade swc_ecma_parser to 0.122.19 - deno_ast 0.20 #16406

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

dsherret
Copy link
Member

Closes #16124

@@ -8,13 +8,13 @@ cover [WILDCARD]/coverage/complex.ts ... 70.175% (40/57)
52 | foo,
53 | bar,
54 | baz,
55 | );
-----|-----
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherret
Copy link
Member Author

Looks like a change in data-url broke some WPT tests:

/fetch/data-urls/processing.any.html

test "data:text/plain;a=\",\",X" ... ok (expected fail)


failures:


expected failures that passed:

        "\"data:text/plain;a=\\\",\\\",X\""

file result: failed. 72 passed; 1 failed; 0 expected failure; total 73

----------------------------------------
/fetch/data-urls/processing.any.worker.html

test "data:text/plain;a=\",\",X" ... ok (expected fail)


failures:


expected failures that passed:

        "\"data:text/plain;a=\\\",\\\",X\""

file result: failed. 72 passed; 1 failed; 0 expected failure; total 73

],
"processing.any.worker.html": [
"\"data:text/plain;a=\\\",\\\",X\""
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like these should be removed? That resolved the CI failure. I'm guessing this is a fix in data-url? cc @lucacasonato

use data_url::DataUrl;

let url = DataUrl::process("data:text/plain;a=\",\",X").unwrap();
let (body, fragment) = url.decode_to_vec().unwrap();
eprintln!("Type: {:?}", url.mime_type());
eprintln!("Body: {:?}", String::from_utf8(body).unwrap());

Output in 0.1.1:

Type: text/plain - Mime { type_: "text", subtype: "plain", parameters: [] }
Body: [34, 44, 88]

Then in 0.2.0:

Type: text/plain;a="" - Mime { type_: "text", subtype: "plain", parameters: [("a", "")] }
Body: [34, 44, 88]

@dsherret dsherret merged commit e203bd9 into denoland:main Oct 25, 2022
@dsherret dsherret deleted the deno_ast_0.20.0 branch October 25, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract Class Field Leaves Initializer on Class
2 participants