chore: workspace inheritance #16343
Merged
chore: workspace inheritance #16343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
requested changes
Oct 18, 2022
There was a problem hiding this comment.
We'll need to make this work with the release scripts before landing.
|
@crowlKats are we still blocked on this PR? |
|
Let's hold off on this until after the 1.28 release. One less thing to deal with as this might break the release scripts. |
I agree, just wanted to touch base on this one as it seems to simplify quite a lot |
|
@bartlomieju something is wrong with one of the tests (op_macro), unsure whats going on with that |
# Conflicts: # bench_util/Cargo.toml # cli/Cargo.toml # cli/napi_sym/Cargo.toml # core/Cargo.toml # ext/broadcast_channel/Cargo.toml # ext/cache/Cargo.toml # ext/console/Cargo.toml # ext/crypto/Cargo.toml # ext/fetch/Cargo.toml # ext/ffi/Cargo.toml # ext/flash/Cargo.toml # ext/http/Cargo.toml # ext/napi/Cargo.toml # ext/net/Cargo.toml # ext/node/Cargo.toml # ext/tls/Cargo.toml # ext/url/Cargo.toml # ext/web/Cargo.toml # ext/webgpu/Cargo.toml # ext/webidl/Cargo.toml # ext/websocket/Cargo.toml # ext/webstorage/Cargo.toml # ops/Cargo.toml # runtime/Cargo.toml # serde_v8/Cargo.toml # test_util/Cargo.toml
dsherret
approved these changes
Nov 22, 2022
# Conflicts: # cli/Cargo.toml
bartlomieju
pushed a commit
that referenced
this pull request
Nov 24, 2022
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to use workspace inheritance.
I only set inheritable deps to be ones that are used multiple times.