feat(runtime): make kill signal optional #16299
Conversation
| @@ -3394,18 +3394,19 @@ declare namespace Deno { | |||
| /** Clean up resources associated with the sub-process instance. */ | |||
| close(): void; | |||
| /** Send a signal to process. | |||
| * Default signal is `"SIGTERM"`. | |||
There was a problem hiding this comment.
Maybe the intellisense/generated documentation is better if we do something like the following?
* @param [signo="SIGTERM"] - Signal to send to the processThere was a problem hiding this comment.
oh interesting, didnt notice thats a thing. quickly checked, and deno_doc doesn't support it, so going to look into adding that first
There was a problem hiding this comment.
Maybe we should wait for microsoft/tsdoc#151 actually. Just noticed that.
There was a problem hiding this comment.
hm, looking at that issue, made me notice microsoft/tsdoc#27, which we actually recently implemented... so maybe it would be fine? because i am in the need for default value for parameters for various documentation related things, so ideally we would implement it as per jsdoc spec. because i honestly have little hope that those tsdoc issues will get resolved anytime soon and being blocked on those for a massive improvement in documentation would just be silly...
|
This is effectively a breaking change to a stable API. What's the reason for it? |
|
I dont think its breaking, as it adds an additional possibility of value being undefined, so any old code should still be working. |
No description provided.