fix(ext/flash) Fix panic when JS caller doesn't consume request body #16173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
littledivy
reviewed
Oct 8, 2022
Co-authored-by: Divy Srivastava <[email protected]>
|
@littledivy please take a look |
|
any updates? |
This was referenced Jan 15, 2023
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2023
…#16173) If the JS handler gets a POST, PUT, or PATCH request, but doesn't `await` the body, deno would panic because it will try to read the body even though the request has already been handled. Not sure how/where to test this case, so I could use some help with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15934, #15759, #15813
If the JS handler gets a POST, PUT, or PATCH request, but doesn't
awaitthe body, deno would panic because it will try to read the body even though the request has already been handled.Not sure how/where to test this case, so I could use some help with that.