Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): fix builtin module module #15904

Merged
merged 2 commits into from
Sep 17, 2022
Merged

fix(ext/node): fix builtin module module #15904

merged 2 commits into from
Sep 17, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 14, 2022

This PR fixes builtin module module in node context. require("module") needs to be Module constructor itself instead of proxy object.

This change enables the example in #15841 (comment)

closes #15841

@kt3k kt3k requested a review from dsherret September 14, 2022 15:10
bartlomieju
bartlomieju approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@kt3k kt3k merged commit d7b27ed into denoland:main Sep 17, 2022
@kt3k kt3k deleted the fix-builtin-module-module branch September 17, 2022 11:35
dsherret pushed a commit that referenced this pull request Sep 22, 2022
@kt3k @dsherret
fix(ext/node): fix builtin module module (#15904)
391108f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compat: tap module can't be run
2 participants
@kt3k @bartlomieju