Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/flash): don't block requests #15852

Merged
merged 8 commits into from
Sep 13, 2022
Merged

fix(ext/flash): don't block requests #15852

merged 8 commits into from
Sep 13, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 10, 2022 •
edited
Loading

Fixes #15758

13% improvement in react-dom SSR

image

  • slight ~3% decrease in Hono routing benchmark but there is a 14% overhead in { headers } logic.
  • no change in plaintext benchmark on OSX / Linux.

@littledivy littledivy marked this pull request as ready for review September 11, 2022 04:06
@littledivy littledivy mentioned this pull request Sep 11, 2022
Closed
sagea
sagea approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@sagea sagea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I posted a comment with a question on a behavior change.

I tested this locally and it works as expected :)

Thanks for fixing this issue!

Screen.Recording.2022-09-11.at.9.03.06.PM.mov

ext/flash/01_http.js Outdated Show resolved Hide resolved
sagea
sagea suggested changes Sep 12, 2022
View reviewed changes
ext/flash/01_http.js Show resolved Hide resolved
ry
ry reviewed Sep 12, 2022
View reviewed changes
ext/flash/01_http.js Outdated Show resolved Hide resolved
ry
ry approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it would be worthwhile to do another clean up commit and go through handleResponse adding comments. It has a lot of branches, is very long, and thus is difficult to follow.

@littledivy littledivy merged commit b26d0b8 into denoland:main Sep 13, 2022
cjihrig pushed a commit that referenced this pull request Sep 15, 2022
@littledivy @cjihrig
fix(ext/flash): don't block requests (#15852)
e65d8af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@sagea sagea sagea requested changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug 1.25.1] (Deno.serve) - Only handles one request at a time
4 participants
@littledivy @ry @sagea @bartlomieju