fix(npm): align Node esm code importing cjs with Node #15838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Sep 10, 2022
littledivy
reviewed
Sep 10, 2022
littledivy
approved these changes
Sep 10, 2022
Co-authored-by: Divy Srivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more aligns Node ESM importing CJS to have the same behaviour as Node, but keeps the current
__esModulecheck that Deno does when importing CJS from npm. Essentially, this allows the Node ESM code to be comptabile with Node and the Deno code can be more comptable with what's done in the JS/TS ecosystem. That said, I suspect we may run into issues doing this though and may want to eventually align Deno's interop with Node's behaviour...