feat(ext/ffi): Support bool FFI type #15754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Sep 5, 2022
kt3k
pushed a commit
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup support for bool types in FFI. This enables both slow and fast API calls using booleans, since Fast API supports boolean to bool bindings.
Support for bools is also added for statics and
Deno.UnsafePointerView.Tests also done and tested, so this should be pretty good as-is.
Dynasmrt Fast API
Adapting Dynasmrt PR to support booleans should be as easy as marking
NativeType::Boolto take the same path asNativeType::U8.