chore(serde_v8): take mutable reference in ToV8::to_v8
#15707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, its not possible to mutatate return value during serialization stage; which is required to support V8 external strings that take ownership of the bytes. Ideally,
to_v8
should take ownership but that doesn't seem possible. With this patch, you could useOption::take
to take ownership (& leak)ByteString
, etc insideto_v8
.