Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): better error for importing ES module via require() call #15671

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

bartlomieju
Copy link
Member

Ref #15642

(doesn't actually fix the problem in the issue above)

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit a938aaf into denoland:main Aug 29, 2022
@bartlomieju bartlomieju deleted the fix_require_error branch August 29, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants