Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set env,key for string and value for string #1567

Merged
merged 1 commit into from
Jan 24, 2019
Merged

fix: set env,key for string and value for string #1567

merged 1 commit into from
Jan 24, 2019

Conversation

caijw
Copy link
Contributor

@caijw caijw commented Jan 23, 2019

for isssue:
#1477

env returns { [index: string]: string }, so the value to set env should also be string.

ry
ry approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thanks.

@ry ry merged commit 2547f02 into denoland:master Jan 24, 2019
@bartlomieju bartlomieju mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caijw @ry