-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/repl): await Promise.any([])... #15623
Conversation
Test code should be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
@bartlomieju Could you please take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @bartlomieju
I'd prefer to land #15548 before this PR. Code looks mostly good to me, though I don't understand why there are these |
I just don't want the whole app to crash when |
Could you provide an example that would trigger such case? CC @nayeemrmn can you take a look as well? |
I don't know the case for now, but since these two are both Options, there has to be a chance to be None 💭 . |
@CGQAQ please rebase |
in REPL crashes with Fatal javascript OOM in Ineffective mark-compacts near heap limit(denoland#15443)
rebased @bartlomieju |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
in REPL crashes with Fatal javascript OOM in Ineffective mark-compacts near heap limit(#15443)
and
fix(ext/console): console.dir 'AggregateError: All promises were rejected' lead to ' Fatal javascript OOM in Ineffective mark-compacts near heap limit' (#14496)
Fixed: #15443
Fixed: #14496 Thanks to @0f-0b for telling me how to