Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/repl): await Promise.any([])... #15623

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Aug 26, 2022

in REPL crashes with Fatal javascript OOM in Ineffective mark-compacts near heap limit(#15443)

and

fix(ext/console): console.dir 'AggregateError: All promises were rejected' lead to ' Fatal javascript OOM in Ineffective mark-compacts near heap limit' (#14496)

Fixed: #15443
Fixed: #14496 Thanks to @0f-0b for telling me how to

@masx200
Copy link

masx200 commented Aug 27, 2022

Test code should be added

Copy link

@masx200 masx200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Aug 30, 2022

@bartlomieju Could you please take a look :)

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @bartlomieju

@bartlomieju
Copy link
Member

I'd prefer to land #15548 before this PR. Code looks mostly good to me, though I don't understand why there are these Unknown exception strings added

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 1, 2022

though I don't understand why there are these Unknown exception strings added

I just don't want the whole app to crash when exception or description is None, any suggestions? @bartlomieju

@bartlomieju
Copy link
Member

though I don't understand why there are these Unknown exception strings added

I just don't want the whole app to crash when exception or description is None, any suggestions? @bartlomieju

Could you provide an example that would trigger such case?

CC @nayeemrmn can you take a look as well?

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 1, 2022

Could you provide an example that would trigger such case?

I don't know the case for now, but since these two are both Options, there has to be a chance to be None 💭 .
And I think it must be a rare case, so I just give an Unknown exception to the description of when it happened

@bartlomieju
Copy link
Member

@CGQAQ please rebase

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 2, 2022

rebased @bartlomieju

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 8178665 into denoland:main Sep 2, 2022
@CGQAQ CGQAQ deleted the fix-15443 branch September 2, 2022 11:38
kt3k pushed a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants