fix: avoid global declaration collisions in cjs #15608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 25, 2022
| "(function (exports, require, module, __filename, __dirname, globalThis) { (function (exports, require, module, __filename, __dirname, globalThis, Buffer, clearImmediate, clearInterval, clearTimeout, global, process, setImmediate, setInterval, setTimeout) {", | ||
| "\n}).call(this, exports, require, module, __filename, __dirname, globalThis, globalThis.Buffer, globalThis.clearImmediate, globalThis.clearInterval, globalThis.clearTimeout, globalThis.global, globalThis.process, globalThis.setImmediate, globalThis.setInterval, globalThis.setTimeout); })", | ||
| "(function (exports, require, module, __filename, __dirname, globalThis) { const { Buffer, clearImmediate, clearInterval, clearTimeout, global, process, setImmediate, setInterval, setTimeout} = globalThis; (function () {", | ||
| "\n}).call(this); })", |
|
The stack overflows on the Windows CI is because of swc parsing the _pico.mjs module in std/node. I'm not sure why it suddenly started happneing, but it happens locally for me too (and I locally increased the stack size to prevent it)... https://github.com/denoland/deno/runs/8027046381?check_suite_focus=true Edit: I bumped it up to *2 instead of *1.5 the default size. Some people were asking to increase it anyway. |
dsherret
commented
Aug 25, 2022
| pub struct CustomNpmPackageCache(HashMap<String, CustomNpmPackage>); | ||
|
|
||
| impl CustomNpmPackageCache { | ||
| pub fn load() -> Result<Self, anyhow::Error> { |
There was a problem hiding this comment.
In the future, this should probably be lazy so it's faster once we start having many packages. I just wrote this as a first pass.
…o much stack size. We should look into this more later though.
bartlomieju
approved these changes
Aug 26, 2022
Comment on lines
+1
to
+6
| # npm test data | ||
|
|
||
| This folder contains test data for npm specifiers. | ||
|
|
||
| ## Registry | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the ability for us to have custom npm packages in the tests, which is what most of this PR is.
Closes #15604