Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): cjs export analysis should take into consideration exports with dashes #15582

Merged
merged 3 commits into from
Aug 24, 2022
Merged

fix(npm): cjs export analysis should take into consideration exports with dashes #15582

merged 3 commits into from
Aug 24, 2022

Conversation

dsherret
Copy link
Member

We're going to add tests for this in the future as one of vite's dependencies causes this.

Essentially, there may be exports like "some-export", which isn't a valid variable name.

bartlomieju
bartlomieju approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 18fcef8 into denoland:main Aug 24, 2022
@dsherret dsherret deleted the fix_exports_with_dashes branch August 24, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju