-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(unstable): various resolution bugs for npm: specifiers #15546
Conversation
There should be assertions verifying that |
2ad9350
to
fe1c305
Compare
|
No 1. is now addressed, but running it again yields another error:
|
This is now fixed as well |
// Trying to import a devDependency should result in an error | ||
await import("xo"); | ||
} catch (e) { | ||
console.error("devDependency import failed:", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use better error message instead of Relative import path "xo" is not prefix with /, ./ or ../
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open a PR with this change later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we should move referrer_package.dependencies.get
to be first instead of last in that one method.
// Trying to import a devDependency should result in an error | ||
await import("xo"); | ||
} catch (e) { | ||
console.error("devDependency import failed:", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open a PR with this change later.
cargo run -- run -A --unstable npm:vite build --debug
cargo run -- run -A --unstable npm:vite@2 build --debug