Fix: Honor linter rules in CI and locally #15492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUSTFLAGS take precedence over `target.<triple>.rustflags`. Therefore, setting the env var globally in CI would always override whatever linter rules are allowed or denied in .cargo/config.toml. With this change, we ensure that problems are detected both in CI and locally, using either cargo clippy or lint.js.
mlafeldt
commented
Aug 18, 2022
| let res = | ||
| // SAFETY: call to libc::sendfile() | ||
| unsafe { libc::sendfile(self.io.1, self.io.0, &mut offset, count) }; |
There was a problem hiding this comment.
This "problem" was detected as a result of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUSTFLAGStake precedence overtarget.<triple>.rustflags. Therefore, setting the env var globally in CI would always override whatever linter rules are allowed or denied in.cargo/config.toml.With this change, we ensure that problems are detected both in CI and locally, using either
cargo clippyorlint.js.For context, in #15453 I moved the lint rules to
.cargo/config.toml.This fix would also unblock #15464 by allowing
clippy::derive-partial-eq-without-eqin CI.