Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): handle storing non-all lowercase package names #15470

Merged
merged 1 commit into from
Aug 14, 2022
Merged

fix(npm): handle storing non-all lowercase package names #15470

merged 1 commit into from
Aug 14, 2022

Conversation

dsherret
Copy link
Member

Package names are not necessarily all lowercase: https://twitter.com/izs/status/1558114479690223621

bartlomieju
bartlomieju approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so it means you won't be able to easily browse DENO_DIR to find npm packages there, is that correct?

@dsherret
Copy link
Member Author

Only for these kind of packages, which I would assume are very rare given I’ve never noticed one.

@dsherret dsherret merged commit 18dcc64 into denoland:main Aug 14, 2022
@dsherret dsherret deleted the fix_npm_handle_storing_case_sensitive_npm_packages branch August 14, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @bartlomieju