refactor(cli): consolidate most MainWorker related code to the same place #15459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
changed the title
dsherret
commented
Aug 11, 2022
| worker.dispatch_unload_event(&located_script_name!())?; | ||
| Ok(0) | ||
| let exit_code = worker.run().await?; | ||
| Ok(exit_code) |
There was a problem hiding this comment.
Change here to include the exit code is mostly a formality and to align with the other methods. It seems like deno eval already returned the exit code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates a lot of the
MainWorkercode into aCliMainWorkerstruct with high level methods. The low level details are then within this class.At the moment, I mostly extracted out this code to this struct, but I think even some more code re-use code occur.
This will allow me to inject some node-compat like stuff into everywhere more easily instead of spreading it around 7ish different places.