Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): importing config as json #15444

Merged
merged 2 commits into from
Aug 10, 2022
Merged

fix(cli): importing config as json #15444

merged 2 commits into from
Aug 10, 2022

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #15440.

kitsonk
kitsonk approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 578f12d into denoland:main Aug 10, 2022
@nayeemrmn nayeemrmn deleted the config-json-import branch August 10, 2022 22:04
bartlomieju pushed a commit to littledivy/deno that referenced this pull request Aug 11, 2022
@nayeemrmn @bartlomieju
fix(cli): allow configurations files to also be json modules (denolan…
35f6b23 
…d#15444)

Closes denoland#15440
dsherret pushed a commit that referenced this pull request Aug 11, 2022
@nayeemrmn @dsherret
fix(cli): allow configurations files to also be json modules (#15444)
ae7b6a4 
Closes #15440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not import JSON config file if the config file specifies jsxImportSource
2 participants
@nayeemrmn @kitsonk