Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily disable ext/node and use unstable ops #15438

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 9, 2022

This code was not using unstable ops and isn't properly permission checked.

Also opened denoland/deno_core#130.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter intuitively #[v8(unstable)] does not actually make an op unstable. The unstable annotation was a half baked feature which was never actually fully implemented.

You'll have to do the unstable check the same way that ext/ffi does.

@lucacasonato
Copy link
Member

I am LGTM on the disabling of the extension, just not on the #[op(unstable)].

@dsherret dsherret merged commit 04d4021 into denoland:main Aug 10, 2022
@dsherret dsherret deleted the chore_temp_disable_ext_node branch August 10, 2022 02:09
bartlomieju pushed a commit to littledivy/deno that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants