feat(repl): Add color to functions #15434
Conversation
cli/tools/repl/editor.rs
Outdated
| @@ -304,7 +305,9 @@ impl Highlighter for EditorHelper { | |||
| fn highlight<'l>(&self, line: &'l str, _: usize) -> Cow<'l, str> { | |||
| let mut out_line = String::from(line); | |||
|
|
|||
| for item in deno_ast::lex(line, deno_ast::MediaType::TypeScript) { | |||
| let mut lexed_items: VecDeque<_> = | |||
| deno_ast::lex(line, deno_ast::MediaType::TypeScript).into(); | |||
There was a problem hiding this comment.
Maybe using peakable() might be more appropriate (https://doc.rust-lang.org/std/iter/struct.Peekable.html)? Then you can use lexed_items.next() and lexed_items.peek()?
| if matches!(next, Some(deno_ast::TokenOrComment::Token(next_token)) if matches!(next_token, Token::LParen)) { | ||
| // We're looking for something that looks like a function | ||
| // We use a simple heuristic: 'ident' followed by 'LParen' | ||
| colors::intense_blue(&line[range]).to_string() |
There was a problem hiding this comment.
I like it. Is there any precedence where other people are doing this too?
There was a problem hiding this comment.
Not sure, I just used this trick before for a repl I have and it worked well
There was a problem hiding this comment.
But its just a heuristic, so it only works for the most part, which I think its fine personally for a repl.
There was a problem hiding this comment.
Maybe we should apply same coloring as in diagnostics coming from TSC or the linter?
There was a problem hiding this comment.
Oh, by precedence I just meant someone else using a different colour for the function names. The heuristic looks good. Anyway, not a big deal.
This pr adds colors to functions
This is all subjective but I thought its nicer to have more colors in general.