fix(vendor): error on dynamic imports that fail to load instead of panicking #15391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 2, 2022
| let err = builder | ||
| .with_loader(|loader| { | ||
| loader.add("/mod.ts", "import 'https://localhost/mod.ts';"); | ||
| loader.add("https://localhost/mod.ts", "await import('./test.ts');"); |
There was a problem hiding this comment.
Interestingly this only occurs for dynamic imports.
dsherret
commented
Aug 2, 2022
| @@ -68,6 +68,14 @@ pub fn build( | |||
| graph.lock()?; | |||
| graph.valid()?; | |||
There was a problem hiding this comment.
Removing this in https://github.com/denoland/deno/pull/15390/files#diff-25670ef0ccc50ba364743d0195b7ed54396876142b482fa36b99926bc1d6b46bL69 because it would error on some bare specifiers in type declarations, which wouldn't occur with deno run even when doing --check=remote.
I kind of feel like this should have surfaced the error though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15215