Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): use correct commit chars for completions #15366

Merged
merged 1 commit into from
Aug 1, 2022
Merged

fix(lsp): use correct commit chars for completions #15366

merged 1 commit into from
Aug 1, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Aug 1, 2022

Fixes: #15252

This ensures that "/" is only a commit character on incomplete registry creations, not on other ones.

@lucacasonato
Copy link
Member

Thanks

@kitsonk kitsonk merged commit 09d14b1 into denoland:main Aug 1, 2022
@kitsonk kitsonk deleted the kitsonk/issue15252 branch August 1, 2022 22:54
crowlKats pushed a commit that referenced this pull request Aug 4, 2022
@kitsonk @crowlKats
fix(lsp): use correct commit chars for completions (#15366)
6305c9c 
Fixes: #15252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: commit chars on import specifiers "wrong"
2 participants
@kitsonk @lucacasonato