Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/lsp): remove excessive line breaks #15364

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix(cli/lsp): remove excessive line breaks #15364

merged 2 commits into from
Aug 1, 2022

Conversation

outloudvi
Copy link
Contributor

Fixes #15359

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@outloudvi
Copy link
Contributor Author

I don't see #[cfg(test)] in this file. I'm wondering are the tests somewhere else or there is no test for this file?

@outloudvi outloudvi marked this pull request as ready for review August 1, 2022 00:51
@kitsonk
Copy link
Contributor

kitsonk commented Aug 1, 2022

Because it is an internal diagnostic page we don't have a test for it.

kitsonk
kitsonk approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 924aa31 into denoland:main Aug 1, 2022
crowlKats pushed a commit that referenced this pull request Aug 4, 2022
@outloudvi @crowlKats
fix(lsp): remove excessive line breaks in status page (#15364)
95fc447 
Fixes #15359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli/lsp: performance table in Server Status has extra line breaks
3 participants
@outloudvi @CLAassistant @kitsonk