Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: turn bare URLs into clickable links #15347

Merged
merged 1 commit into from
Jul 30, 2022
Merged

docs: turn bare URLs into clickable links #15347

merged 1 commit into from
Jul 30, 2022

Conversation

mlafeldt
Copy link
Contributor

Thereby fixing all cargo doc warnings of this kind:

  warning: this URL is not a hyperlink
     --> cli/cdp.rs:413:5
      |
  413 | /// https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-ExecutionContextId
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-ExecutionContextId>`
      |
      = note: bare URLs are not automatically turned into clickable links

@mlafeldt
docs: turn bare URLs into clickable links
f99f5db 
Thereby fixing all `cargo doc` warnings of this kind:

  warning: this URL is not a hyperlink
     --> cli/cdp.rs:413:5
      |
  413 | /// https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-ExecutionContextId
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-ExecutionContextId>`
      |
      = note: bare URLs are not automatically turned into clickable links
bartlomieju
bartlomieju approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju bartlomieju merged commit 3f0dcd3 into denoland:main Jul 30, 2022
@mlafeldt mlafeldt deleted the clickable-doc-links branch July 30, 2022 11:17
crowlKats pushed a commit that referenced this pull request Aug 4, 2022
@mlafeldt @crowlKats
docs: turn bare URLs into clickable links (#15347)
f1a80fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlafeldt @bartlomieju