Add globalThis definition to runtime #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Jan 16, 2019
|
@ry updated and the failure seems to be a transient Travis issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globalThisproposal has reached Stage 3: https://github.com/tc39/proposal-global and has been in V8 for a while now.This PR adds it to the runtime type library for Deno so that users can access it. It shares the same interface as
windowandglobalThis === windowwithout any additional runtime code to be added.I tried to replace our use of
globalEvalwithglobalThisin the runtime code, but it appears that when snapshotting,globalThisis not available for some reason.