fix(ext/ffi): Check CStr for UTF-8 validity on read #15318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phosra Ping for review. |
Added a test that verifies both that the EDIT: Here's what the
|
vimirage
reviewed
Jul 28, 2022
vimirage
approved these changes
Jul 28, 2022
vimirage
reviewed
Jul 28, 2022
Co-authored-by: Phosra <[email protected]>
littledivy
approved these changes
Aug 5, 2022
dsherret
pushed a commit
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Phosra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous performance work on
op_ffi_cstr_readwas a bit too optimistic about what it can do.This PR fixes the optimism by properly checking for UTF-8 validity before giving the bytes to V8 for
v8::Stringcreation.