Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch/body): Fix TODOs about WebIDL conversions #15312

Merged
merged 3 commits into from Jul 28, 2022
Merged

fix(fetch/body): Fix TODOs about WebIDL conversions #15312

merged 3 commits into from Jul 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2022

Adds a converter for URLSearchParams, and uses the two missing converters in fetch/body.

@ghost ghost marked this pull request as ready for review July 26, 2022 07:08
@ry ry requested a review from lucacasonato July 27, 2022 14:31
lucacasonato
lucacasonato reviewed Jul 28, 2022
View reviewed changes
ext/url/00_url.js Outdated Show resolved Hide resolved
@lucacasonato
Fix URLSearchParams
edaee45 
Co-authored-by: Luca Casonato <[email protected]>
lucacasonato
lucacasonato approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lucacasonato lucacasonato merged commit 519ed44 into denoland:main Jul 28, 2022
@ghost ghost deleted the patch-3 branch July 28, 2022 11:22
cjihrig pushed a commit that referenced this pull request Jul 28, 2022
@cjihrig
fix(ext/fetch): resolve TODOs about WebIDL conversions in body init (#…
bf96af9 
…15312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lucacasonato